Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Obsolete product handling #9

Merged
merged 10 commits into from
Oct 12, 2023
Merged

feat: Obsolete product handling #9

merged 10 commits into from
Oct 12, 2023

Conversation

john-gom
Copy link
Collaborator

No description provided.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

async count(body: any) {
const start = Date.now();
this.logger.debug(body);

const obseleteWhere = this.obsoleteWhere(body);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const obseleteWhere = this.obsoleteWhere(body);
const obsoleteWhere = this.obsoleteWhere(body);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eagle eye 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really have trouble spelling that word!

Copy link

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@john-gom john-gom merged commit 35b2a1f into main Oct 12, 2023
1 check passed
@john-gom john-gom deleted the obsolete-handling branch October 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants